Add CinderSpecCore struct #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test cinder-operator-build-deploy-tempest |
dprince
force-pushed
the
core_api
branch
3 times, most recently
from
b701dd4 to
f720d56
Compare
ASBishop
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Dan, I assume this is all part of the migration to using "openstackversions" to manage container images. What's the state of that effort? We don't want to lose the ability to manage cinder-volume's container images if there will be a time lag between merging this PR and when "openstackversions" will be ready.
Akrog
requested changes
Mar 4, 2024
This version of the struct (called "core") is meant to be used via the OpenStackControlplane. It is the same as CinderSpec only it is missing the containerImages from the nested API, Backup, Scheduler, and Volume specs. The Default() function for webhooks has been split accordingly. Jira: OSPRH-4835
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, dprince The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 64cafe6
into
openstack-k8s-operators:main
7 checks passed
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…anup Webhook cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of the struct (called "core") is meant to be used via the OpenStackControlplane. It is the same as CinderSpec only it is missing the containerImages parameters from the nested API, Backup, Scheduler, and Volume specs.
This is useful to prevent users from interacting with these
parameters directly via the OpenStackControlplane